mmk2410
/
my-todo-list
Archived
1
0
Fork 0
Code Releases Activity

Refactored Todo::validateState

This commit is contained in:
Marcel Kapfer 2021-09-18 22:49:39 +02:00
parent df0dd98d7c
commit f723e0e8c4
Signed by: mmk2410
GPG Key ID: CADE6F0C09F21B09
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Todo.php
View File

@ -5,6 +5,7 @@ namespace MMK2410\MyTodoList;
class Todo class Todo
{ {
const ExceptionMsgInvalidTitle = "Empty task title not allowed"; const ExceptionMsgInvalidTitle = "Empty task title not allowed";
const ExceptionMsgInvalidState = "Invalid state tried to set.";
private string $title; private string $title;
private string $state; private string $state;
@ -50,7 +51,7 @@ class Todo
$reflect = new \ReflectionClass(TodoStates::class); $reflect = new \ReflectionClass(TodoStates::class);
$constantFound = $reflect->getConstant($state); $constantFound = $reflect->getConstant($state);
if ($constantFound === FALSE) { if ($constantFound === FALSE) {
throw new \InvalidArgumentException("Invalid state tried to set."); throw new \InvalidArgumentException(self::ExceptionMsgInvalidState);
} }
} }
} }

2
tests/TodoTest.php
View File

@ -61,7 +61,7 @@ class TodoTest extends TestCase
{ {
$todo = new Todo("stub"); $todo = new Todo("stub");
$this->expectException(\InvalidArgumentException::class); $this->expectException(\InvalidArgumentException::class);
$this->expectExceptionMessage("Invalid state tried to set."); $this->expectExceptionMessage(Todo::ExceptionMsgInvalidState);
$todo->setState("bogus"); $todo->setState("bogus");
} }
} }