mmk2410/rangitaki
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Better code with isset()

Browse source
This commit is contained in:
Marcel Kapfer (mmk2410) 2016-04-18 09:53:47 +02:00
parent 6d1928da70
commit cb491341df
8 changed files with 374 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
rcc/api/post/index.php
View file

@ -30,7 +30,7 @@ if ($settings["rcc"]["api"] == "on" && $settings["rcc"]["rcc"] == "on") {
$blog = $_GET["blog"];
$post = $_GET["post"];
if (!$blog || !$post) {
if (!isset($blog) || !isset($post)) {
$data = array('code' => 400, 'status' => 'Bad Request', 'error' => 'Not enough arguments');
$response = $response->withHeader('Content-type', 'application/json');
$response = $response->withJson($data, 400);
@ -61,7 +61,7 @@ if ($settings["rcc"]["api"] == "on" && $settings["rcc"]["rcc"] == "on") {
$tags = $_POST["tags"];
$text = $_POST["text"];
if (!$blog || !$post || (!$title && !$text)) {
if (!isset($blog) || !isset($post) || (!isset($title) && !isset($text))) {
$data = array('code' => 400, 'status' => 'Bad Request', 'error' => 'Not enough arguments');
$response = $response->withHeader('Content-type', 'application/json');
$response = $response->withJson($data, 400);
@ -105,7 +105,7 @@ EOD;
$blog = $_GET["blog"];
$post = $_GET["post"];
if (!$blog || !$post) {
if (!isset($blog) || !isset($post)) {
$data = array('code' => 400, 'status' => 'Bad Request', 'error' => 'Not enough arguments');
$response = $response->withHeader('Content-type', 'application/json');
$response = $response->withJson($data, 400);