mmk2410/plausible_analytics
1
0
Fork 0
Code Issues Pull requests Releases 2 Activity

♻️ Use already existing asset collector

Browse source 
For some reason the AssetCollector instance created (or passed) in the
PageRendererPreProcess constructor was not used, but instead a new
instance was made as part of the addLibrary function.

This commit refactors PageRendererPreProcess::addLibrary to use the
already created AssetCollector.
This commit is contained in:
Marcel Kapfer 2022-08-10 18:48:26 +02:00
parent 9c43bfc8f5
commit 09f9578d20
Signed by: mmk2410
GPG key ID: CADE6F0C09F21B09
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Classes/Hooks/PageRendererPreProcess.php
View file

@ -29,8 +29,7 @@ class PageRendererPreProcess
$plausible = $this->getPlausibleURL(); $plausible = $this->getPlausibleURL();
if (isset($domain) && isset($plausible) && !$this->tsfe->isBackendUserLoggedIn()) { if (isset($domain) && isset($plausible) && !$this->tsfe->isBackendUserLoggedIn()) {
GeneralUtility::makeInstance(AssetCollector::class) $this->assetCollector->addJavaScript(
->addJavaScript(
'plausible_analytics', 'plausible_analytics',
$plausible . '/js/plausible.js', $plausible . '/js/plausible.js',
[ [